-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discovery server minimal example #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
rsanchez15
requested changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also create another item in the Core Tutorials for Discovery Server Tutorial and call this one "Minimal Discovery Server deployment" or something similar.
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/deployment/discoveryserver/discovery_server.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
rsanchez15
requested changes
Nov 22, 2023
docs/rst/tutorials/core/discoveryserver/discoveryserver_tutorials.rst
Outdated
Show resolved
Hide resolved
...ials/core/discoveryserver/discoveryserverminimalexample/discovery_server_minimal_example.rst
Outdated
Show resolved
Hide resolved
...ials/core/discoveryserver/discoveryserverminimalexample/discovery_server_minimal_example.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/discoveryserver/discoveryserver_tutorials.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Lucia Echevarria <[email protected]>
rsanchez15
approved these changes
Dec 12, 2023
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Add discovery server minimal example Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (fixed) Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (changed) Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (changed fixed) Signed-off-by: Lucia Echevarria <[email protected]> * Final changes in structure of Discovery Server tutorial Signed-off-by: Lucia Echevarria <[email protected]> * Final changes in structure of Discovery Server tutorial (changes made) Signed-off-by: Lucia Echevarria <[email protected]> --------- Signed-off-by: Lucia Echevarria <[email protected]> (cherry picked from commit 1ff9136)
rsanchez15
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Add discovery server minimal example Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (fixed) Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (changed) Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (changed fixed) Signed-off-by: Lucia Echevarria <[email protected]> * Final changes in structure of Discovery Server tutorial Signed-off-by: Lucia Echevarria <[email protected]> * Final changes in structure of Discovery Server tutorial (changes made) Signed-off-by: Lucia Echevarria <[email protected]> --------- Signed-off-by: Lucia Echevarria <[email protected]> (cherry picked from commit 1ff9136)
rsanchez15
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Add discovery server minimal example Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (fixed) Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (changed) Signed-off-by: Lucia Echevarria <[email protected]> * Add discovery server minimal example (changed fixed) Signed-off-by: Lucia Echevarria <[email protected]> * Final changes in structure of Discovery Server tutorial Signed-off-by: Lucia Echevarria <[email protected]> * Final changes in structure of Discovery Server tutorial (changes made) Signed-off-by: Lucia Echevarria <[email protected]> --------- Signed-off-by: Lucia Echevarria <[email protected]> (cherry picked from commit 1ff9136) Co-authored-by: LuciaEchevarria99 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.